feat: Add support for HBase versions 2.0.0 to 2.5.0.#18253
Merged
Conversation
otelbot-java-instrumentation
Bot
added
the
test native
Member
|
hi @YaoYingLong! I'm going to convert this PR to draft, once you get CI passing or have any questions for us, please mark it ready for review, thanks |
Contributor
Author
@trask CI checks completed. |
Comment on lines
+38
to
+40
| @Advice.OnMethodEnter(suppress = Throwable.class) | ||
| public static void onEnter( | ||
| @Advice.This Object call, @Advice.FieldValue(value = "error") IOException error) { |
Comment on lines
+32
to
+34
| transformer.applyAdviceToMethod( | ||
| isMethod().and(named("callComplete").or(named("setTimeout"))), | ||
| IpcCallInstrumentation.class.getName() + "$CallAdvice"); |
laurit
reviewed
May 21, 2026
laurit
reviewed
May 21, 2026
laurit
reviewed
May 21, 2026
laurit
reviewed
May 21, 2026
laurit
reviewed
May 21, 2026
laurit
reviewed
May 21, 2026
laurit
reviewed
May 21, 2026
laurit
reviewed
May 21, 2026
laurit
reviewed
May 21, 2026
Contributor
Author
laurit
reviewed
Jun 3, 2026
laurit
reviewed
Jun 3, 2026
laurit
reviewed
Jun 3, 2026
laurit
reviewed
Jun 3, 2026
Contributor
Author
|
@laurit All issues found in the review have been fixed. Please review again. |
Comment on lines
+124
to
+129
| return new GenericContainer<>(DockerImageName.parse("harisekhon/hbase:2.0")) | ||
| .withCreateContainerCmdModifier( | ||
| cmd -> | ||
| cmd.getHostConfig() | ||
| .withPortBindings( | ||
| new PortBinding(Ports.Binding.bindPort(2181), new ExposedPort(2181)), |
laurit
approved these changes
Jun 5, 2026
Contributor
|
Thank you for your contribution @YaoYingLong! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for HBase versions [2.0.0, 2.5.0)